| Subject: | This line of code is unecessary:... |
|---|
| Summary: | Package rating comment |
|---|
| Messages: | 2 |
|---|
| Author: | Artur Graniszewski |
|---|
| Date: | 2011-03-23 14:52:20 |
|---|
| Update: | 2011-07-21 14:12:21 |
|---|
| |
|
|
Artur Graniszewski rated this package as follows:
| Utility: | Good |
|---|
| Consistency: | Good |
|---|
| Examples: | Sufficient |
|---|
|
|
 Artur Graniszewski - 2011-03-23 14:52:28 This line of code is unecessary:
if(version_compare(PHP_VERSION, '5.3.0', '<'))
die('These classes are using Closures and other features that are available since PHP version 5.3.0. You are running PHP version '.PHP_VERSION.'. Please update your PHP.');
Because of closures in the source code, PHP 5.0+ will raise a parse error before the above line would be executed.
Another thing. You are using fluent interfaces, so will you try to port this class to PHP 5.0+? It's possible from the technical point of view.
 Kai Dorschner - 2011-07-21 14:12:21 - In reply to message 1 from Artur GraniszewskiThanks for the info Artur!
I think a downward compatible think won't be realisable because of the Prototype Pattern I'm using. This needs Closures.
Greets,
Kai
|
